Remove SBV from the SMT backend #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…references are prestate)
kjekac
reviewed
Apr 28, 2021
|
I took it upon myself to just go ahead and commit all the redundant parentheses I encountered since that seemed like a no-brainer 🙃 still one other suggestion open though and may add more. Looks very good in general though, I'm really just nitpicking. |
kjekac
reviewed
Apr 28, 2021
MrChico
reviewed
Apr 28, 2021
Co-authored-by: MrChico <[email protected]>
Co-authored-by: Jack Ek <[email protected]>
kjekac
approved these changes
Apr 28, 2021
MrChico
reviewed
Apr 28, 2021
|
this is really nice! Can we add a test for #58 now that it works? |
Co-authored-by: Jack Ek <[email protected]>
done. |
MrChico
approved these changes
Apr 28, 2021
|
I already approved before the new test so I can't do it again but looks great :) |
leonardoalt
reviewed
Apr 29, 2021
|
|
||
| invariants | ||
|
|
||
| b[a] == 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the SMT backend to remove the usage of the sbv library. We now generate smt2 directly in
SMT.hswithout going through an additional abstraction layer.The primary motivation for this change was to allow the encoding of mappings in act as arrays in SMT. Doing this with sbv was surprisingly hard (sbv uses tuples for array indicies, act uses a nonempty list), and would have required either extensive modifications to the structure of the AST, significant additional boilerplate, or template haskell.
There are some additional benefits regarding auditability and debugging: the new SMT backend is less than 500 lines (compared to many thousand for sbv), and the resulting queries are significantly more readable.
The big disadvantage here is that we have to keep the sbv based code around for interfacing with
hevm(which still relies on sbv for now), this is unfortunate, but seems to be a price worth paying given the alternatives.CLI output is currently very rough, and counterexamples are currently not generated, I intend to work on this next.
This PR closes the following issues: #62, #72, #91, #58